-
Notifications
You must be signed in to change notification settings - Fork 0
Initial API #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Initial API #1
Conversation
schuyler1d
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not one of our standard frameworks, so I have more questions than would be usual (though I'd support pushing myself and all of us to document even with our more familiar ones).
- How do I run this locally to see how the web api works? Having
def mainin non-script files wasn't super-intuitive. - What is the security model? Is this behind a VPN? Who is given keys or how are they generated?
Slightly more meta -- connecting with a progressive vendor (actionkit) and exporting a CSV seems pretty inside [parsons[(https://github.com/move-coop/parsons/) wheelhouse -- would be worth considering using it (and contributing) rather than more query code to maintain ourselves.
|
I added more documentation in the PyWell repo on how to run locally. Short version: just run I think https://github.com/awslabs/aws-sam-cli can also be used to run lambdas with local web interfaces, though I haven't tried that. Nothing about PyWell requires the functions be named I'm not really trying to evangelize PyWell here, which is why it wasn't explained at all. Ideally the code would be more self-explanatory without any mention of PyWell, but maybe that's not possible. The security model for this is somewhat independent of the code, and could be a little different for different instances. For MoveOn, the current plan is the key generation would be restricted to staff on VPN, who would then share individual keys with partners, who could then use the keys on an unrestricted site. I'm interested in seeing how a Parsons version of this would compare, but I'm a little skeptical this code can get much smaller without making it too abstract. E.g. Seems like the biggest opportunity to minimize the code further is moving the query out of the code, but I think that would make this more of an open-ended keyed query tool and have much wider security concerns. |
This is everything described in the README, minus the static site, which will be the next PR.